tanner/firebird
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: Simplify interrupt handling

Browse Source
This commit is contained in:
Tanner Collin
2025-06-05 11:07:17 -06:00
committed by Tanner Collin (aider)
parent d36b86929d
commit 648924cf60
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tach/tach.ino
+2 -8
View File
@@ -50,12 +50,10 @@ void loop() {
unsigned long current_time = millis(); unsigned long current_time = millis();
if (current_time - last_measurement_time >= MEASUREMENT_PERIOD_MS) { if (current_time - last_measurement_time >= MEASUREMENT_PERIOD_MS) {
detachInterrupt(digitalPinToInterrupt(TACH_INTERRUPT_PIN)); //detachInterrupt(digitalPinToInterrupt(TACH_INTERRUPT_PIN));
unsigned long collected_pulses = pulse_count; unsigned long collected_pulses = pulse_count;
pulse_count = 0; pulse_count = 0;
// It's important to re-attach the interrupt as soon as possible //attachInterrupt(digitalPinToInterrupt(TACH_INTERRUPT_PIN), count_pulse, RISING);
// to minimize missed pulses.
attachInterrupt(digitalPinToInterrupt(TACH_INTERRUPT_PIN), count_pulse, RISING);
// Calculate RPM // Calculate RPM
// RPM = (pulses / pulses_per_revolution) / (measurement_period_ms / 1000 / 60) // RPM = (pulses / pulses_per_revolution) / (measurement_period_ms / 1000 / 60)
@@ -65,10 +63,6 @@ void loop() {
int rpm = (int)rpm_float; int rpm = (int)rpm_float;
show(rpm); show(rpm);
Serial.print("Pulses: ");
Serial.print(collected_pulses);
Serial.print(", RPM: ");
Serial.println(rpm);
last_measurement_time = current_time; last_measurement_time = current_time;
} }