tanner/unnamed-cad-software
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Prevent crash from failed sketch geometry creation

Browse Source 
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
This commit is contained in:
Tanner Collin
2026-02-17 18:12:08 -07:00
parent 6e729183ef
commit b9860f3de0
1 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/SketchFeature.cpp
View File

@@ -54,7 +54,10 @@ void SketchFeature::buildShape()
for (SketchObject* obj : m_objects) { for (SketchObject* obj : m_objects) {
if (auto line = dynamic_cast<SketchLine*>(obj)) { if (auto line = dynamic_cast<SketchLine*>(obj)) {
lineEdges.append(BRepBuilderAPI_MakeEdge(line->startPoint(), line->endPoint()).Edge()); BRepBuilderAPI_MakeEdge makeEdge(line->startPoint(), line->endPoint());
if (makeEdge.IsDone()) {
lineEdges.append(makeEdge.Edge());
}
} else if (auto rect = dynamic_cast<SketchRectangle*>(obj)) { } else if (auto rect = dynamic_cast<SketchRectangle*>(obj)) {
const gp_Pnt& c1 = rect->corner1(); const gp_Pnt& c1 = rect->corner1();
const gp_Pnt& c2 = rect->corner2(); const gp_Pnt& c2 = rect->corner2();
@@ -71,17 +74,19 @@ void SketchFeature::buildShape()
other_corner2.SetCoord(c1.X(), c2.Y(), c1.Z()); other_corner2.SetCoord(c1.X(), c2.Y(), c1.Z());
} }
TopoDS_Edge e1 = BRepBuilderAPI_MakeEdge(c1, other_corner1).Edge(); BRepBuilderAPI_MakeEdge me1(c1, other_corner1);
TopoDS_Edge e2 = BRepBuilderAPI_MakeEdge(other_corner1, c2).Edge(); BRepBuilderAPI_MakeEdge me2(other_corner1, c2);
TopoDS_Edge e3 = BRepBuilderAPI_MakeEdge(c2, other_corner2).Edge(); BRepBuilderAPI_MakeEdge me3(c2, other_corner2);
TopoDS_Edge e4 = BRepBuilderAPI_MakeEdge(other_corner2, c1).Edge(); BRepBuilderAPI_MakeEdge me4(other_corner2, c1);
BRepBuilderAPI_MakeWire wireBuilder(e1, e2, e3, e4); if (me1.IsDone() && me2.IsDone() && me3.IsDone() && me4.IsDone()) {
BRepBuilderAPI_MakeWire wireBuilder(me1.Edge(), me2.Edge(), me3.Edge(), me4.Edge());
if (wireBuilder.IsDone()) { if (wireBuilder.IsDone()) {
BRepBuilderAPI_MakeFace faceBuilder(wireBuilder.Wire()); BRepBuilderAPI_MakeFace faceBuilder(wireBuilder.Wire());
if (faceBuilder.IsDone()) { if (faceBuilder.IsDone()) {
faces.append(faceBuilder.Face()); faces.append(faceBuilder.Face());
} }
} }
}
} else if (auto circle = dynamic_cast<SketchCircle*>(obj)) { } else if (auto circle = dynamic_cast<SketchCircle*>(obj)) {
const gp_Pnt& center = circle->center(); const gp_Pnt& center = circle->center();
double radius = circle->radius(); double radius = circle->radius();
@@ -93,7 +98,9 @@ void SketchFeature::buildShape()
} }
gp_Ax2 axis(center, normal); gp_Ax2 axis(center, normal);
gp_Circ circ(axis, radius); gp_Circ circ(axis, radius);
TopoDS_Edge edge = BRepBuilderAPI_MakeEdge(circ).Edge(); BRepBuilderAPI_MakeEdge makeEdge(circ);
if (makeEdge.IsDone()) {
TopoDS_Edge edge = makeEdge.Edge();
BRepBuilderAPI_MakeWire wireBuilder(edge); BRepBuilderAPI_MakeWire wireBuilder(edge);
if(wireBuilder.IsDone()) { if(wireBuilder.IsDone()) {
BRepBuilderAPI_MakeFace faceBuilder(wireBuilder.Wire()); BRepBuilderAPI_MakeFace faceBuilder(wireBuilder.Wire());
@@ -103,6 +110,7 @@ void SketchFeature::buildShape()
} }
} }
} }
}
if (!lineEdges.isEmpty()) { if (!lineEdges.isEmpty()) {
BRepBuilderAPI_MakeWire wireBuilder; BRepBuilderAPI_MakeWire wireBuilder;