From d3a4be7c01ce94140a3fda2ae448f5f3a3330898 Mon Sep 17 00:00:00 2001 From: Tanner Collin Date: Sat, 7 Feb 2026 12:02:55 -0700 Subject: [PATCH] refactor: Flatten `navidrome_set_rating` function Co-authored-by: aider (gemini/gemini-2.5-pro) --- main.py | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/main.py b/main.py index 446f0c0..fa69fce 100644 --- a/main.py +++ b/main.py @@ -108,20 +108,24 @@ async def navidrome_set_rating(song_id): async with session.get(api_url, params=params) as response: response.raise_for_status() data = await response.json() - if data.get('subsonic-response', {}).get('status') == 'ok': - details = await navidrome_get_song_details(song_id) - if details: - raw_tags = details.get('rawTags', {}) - title = raw_tags.get('title', ['Unknown Title'])[0] - artist = raw_tags.get('artist', ['Unknown Artist'])[0] - album = raw_tags.get('album', ['Unknown Album'])[0] - logging.info(f'Set song "{title}" - {artist} ({album}) rating to 1.') - else: - logging.info(f"Successfully set rating for song {song_id} to 1, but couldn't get song details.") - else: - logging.error(f"Failed to set rating for song {song_id}. Response: {data}") except aiohttp.ClientError as e: logging.error(f"Error calling Navidrome API for song {song_id}: {e}") + return + + if data.get('subsonic-response', {}).get('status') != 'ok': + logging.error(f"Failed to set rating for song {song_id}. Response: {data}") + return + + details = await navidrome_get_song_details(song_id) + if not details: + logging.info(f"Successfully set rating for song {song_id} to 1, but couldn't get song details.") + return + + raw_tags = details.get('rawTags', {}) + title = raw_tags.get('title', ['Unknown Title'])[0] + artist = raw_tags.get('artist', ['Unknown Artist'])[0] + album = raw_tags.get('album', ['Unknown Album'])[0] + logging.info(f'Set song "{title}" - {artist} ({album}) rating to 1.') async def main():