Merge pull request #284 from damageboy/master

Resolve majority of clang+libstdc++ warnings

.editorconfig

@@ -0,0 +1,25 @@
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*.{h,cpp}]
+end_of_line = lf
+indent_style = space
+indent_size = 4
+insert_final_newline = true
+
+# Matches multiple files with brace expansion notation
+# Set default charset
+[*.json]
+charset = utf-8
+end_of_line = lf
+indent_style = space
+indent_size = 4
+insert_final_newline = true
+
+# 4 space indentation
+[CMakeLists.txt]
+end_of_line = lf
+indent_style = space
+indent_size = 4
+insert_final_newline = true

src/logid/actions/Action.h

@@ -63,6 +63,8 @@ namespace actions {
 
         virtual uint8_t reprogFlags() const = 0;
 
+        virtual ~Action() = default;
+
         class Config
         {
         protected:

src/logid/actions/gesture/Gesture.h

@@ -31,7 +31,7 @@ namespace actions
         explicit InvalidGesture(std::string what="") : _what (what)
         {
         }
-        virtual const char* what()
+        virtual const char* what() const noexcept
         {
             return _what.c_str();
         }
@@ -49,6 +49,8 @@ namespace actions
         virtual bool wheelCompatibility() const = 0;
         virtual bool metThreshold() const = 0;
 
+        virtual ~Gesture() = default;
+
         class Config
         {
         public:

src/logid/backend/dj/Receiver.h

@@ -49,7 +49,7 @@ namespace dj
         Reason _reason;
     };
 
-    class Receiver
+    class Receiver final
     {
     public:
         explicit Receiver(std::string path);

src/logid/backend/dj/ReceiverMonitor.h

@@ -33,7 +33,7 @@ namespace dj
     {
     public:
         explicit ReceiverMonitor(std::string path);
-        ~ReceiverMonitor();
+        virtual ~ReceiverMonitor();
 
         void enumerate();
         void run();

src/logid/backend/hidpp20/Feature.h

@@ -41,6 +41,7 @@ namespace hidpp20 {
         static const uint16_t ID;
         virtual uint16_t getID() = 0;
         uint8_t featureIndex();
+        virtual ~Feature() = default;
     protected:
         explicit Feature(Device* dev, uint16_t _id);
         std::vector<uint8_t> callFunction(uint8_t function_id,

src/logid/backend/hidpp20/features/ReprogControls.h

@@ -122,7 +122,7 @@ namespace hidpp20
     {
     public:
         static const uint16_t ID = FeatureID::REPROG_CONTROLS_V2;
-        virtual uint16_t getID() { return ID; }
+        virtual uint16_t getID() override { return ID; }
 
         explicit ReprogControlsV2(Device* dev);
     protected:
@@ -133,7 +133,7 @@ namespace hidpp20
     {
     public:
         static const uint16_t ID = FeatureID::REPROG_CONTROLS_V2_2;
-        virtual uint16_t getID() { return ID; }
+        virtual uint16_t getID() override { return ID; }
 
         explicit ReprogControlsV2_2(Device* dev);
     protected:
@@ -144,7 +144,7 @@ namespace hidpp20
     {
     public:
         static const uint16_t ID = FeatureID::REPROG_CONTROLS_V3;
-        virtual uint16_t getID() { return ID; }
+        virtual uint16_t getID() override { return ID; }
 
         explicit ReprogControlsV3(Device* dev);
     protected:
@@ -155,7 +155,7 @@ namespace hidpp20
     {
     public:
         static const uint16_t ID = FeatureID::REPROG_CONTROLS_V4;
-        virtual uint16_t getID() { return ID; }
+        virtual uint16_t getID() override { return ID; }
 
         bool supportsRawXY() override { return true; }
 

src/logid/backend/raw/DeviceMonitor.h

@@ -40,7 +40,7 @@ namespace raw
         void stop();
     protected:
         DeviceMonitor();
-        ~DeviceMonitor();
+        virtual ~DeviceMonitor();
         virtual void addDevice(std::string device) = 0;
         virtual void removeDevice(std::string device) = 0;
     private:

src/logid/features/DeviceFeature.h

@@ -43,6 +43,7 @@ namespace features
         }
         virtual void configure() = 0;
         virtual void listen() = 0;
+        virtual ~DeviceFeature() = default;
         class Config
         {
         public: