From 48399a1dd474e52881f29a83b9b07830327edd71 Mon Sep 17 00:00:00 2001 From: pixl Date: Sat, 13 Mar 2021 17:55:53 -0500 Subject: [PATCH] Fix ThumbWheel feature direction bug Should fix #145 for the MX Master 3 --- src/logid/features/ThumbWheel.cpp | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/src/logid/features/ThumbWheel.cpp b/src/logid/features/ThumbWheel.cpp index 57bb055..285d72b 100644 --- a/src/logid/features/ThumbWheel.cpp +++ b/src/logid/features/ThumbWheel.cpp @@ -142,23 +142,15 @@ void ThumbWheel::_handleEvent(hidpp20::ThumbWheel::ThumbwheelEvent event) if(event.rotation) { int8_t direction = event.rotation > 0 ? 1 : -1; std::shared_ptr scroll_action; - std::shared_ptr opposite_scroll; - if(event.rotation > 0) { + if(direction > 0) scroll_action = _config.rightAction(); - opposite_scroll = _config.leftAction(); - } else { + else scroll_action = _config.leftAction(); - opposite_scroll = _config.rightAction(); - } - if(direction != _last_direction) { - if(opposite_scroll) - opposite_scroll->release(); - if(scroll_action) { - scroll_action->press(true); - scroll_action->move(direction * event.rotation); - } + if(scroll_action) { + scroll_action->press(true); + scroll_action->move(direction * event.rotation); } _last_direction = direction;